Messages in this thread | | | From | Måns Rullgård <> | Subject | Re: [PATCH v2 2/2] dmaengine: dw: fix cyclic transfer callbacks | Date | Mon, 11 Jan 2016 14:14:00 +0000 |
| |
Viresh Kumar <viresh.kumar@linaro.org> writes:
> On 11-01-16, 13:04, Mans Rullgard wrote: >> Cyclic transfer callbacks rely on block completion interrupts which were >> disabled in commit ff7b05f29fd4 ("dmaengine/dw_dmac: Don't handle block >> interrupts"). This re-enables block interrupts so the cyclic callbacks >> can work. Other transfer types are not affected as they set the INT_EN >> bit only on the last block. >> >> Fixes: ff7b05f29fd4 ("dmaengine/dw_dmac: Don't handle block interrupts") >> Signed-off-by: Mans Rullgard <mans@mansr.com> >> --- >> Changes: >> - new patch >> --- >> drivers/dma/dw/core.c | 21 +++++++++++++++------ >> 1 file changed, 15 insertions(+), 6 deletions(-) > > Reviewed-by: Viresh Kumar <viresh.kumar@linaro.org> > > BTW, Shouldn't you mark these for stable trees as well ? :)
Probably. Some maintainers prefer to do that themselves, but apparently you're not one of them.
-- Måns Rullgård
| |