Messages in this thread | | | Date | Mon, 11 Jan 2016 08:55:55 +0000 | From | Lee Jones <> | Subject | Re: [PATCH v5 5/6] mfd: dt-bindings: add device tree bindings for Hi3519 sysctrl |
| |
On Mon, 11 Jan 2016, xuejiancheng wrote: > On 2016/1/11 13:48, Lee Jones wrote: > > On Fri, 08 Jan 2016, Jiancheng Xue wrote: > > > >> Add device tree bindings for Hi3519 system controller. > >> > >> Signed-off-by: Jiancheng Xue <xuejiancheng@huawei.com> > >> --- > >> Documentation/devicetree/bindings/mfd/hi3519.txt | 14 ++++++++++++++ > >> 1 file changed, 14 insertions(+) > >> create mode 100644 Documentation/devicetree/bindings/mfd/hi3519.txt > > > > I have this patch, but none of the others in the set, thus I am > > lacking context. > > > I can forward other patches in the set to you. Thank you. > > >> diff --git a/Documentation/devicetree/bindings/mfd/hi3519.txt b/Documentation/devicetree/bindings/mfd/hi3519.txt > >> new file mode 100644 > >> index 0000000..115c5be > >> --- /dev/null > >> +++ b/Documentation/devicetree/bindings/mfd/hi3519.txt > >> @@ -0,0 +1,14 @@ > >> +* Hisilicon Hi3519 System Controller Block > >> + > >> +This bindings use the following binding: > >> +Documentation/devicetree/bindings/mfd/syscon.txt > >> + > >> +Required properties: > >> +- compatible: "hisilicon,hi3519-sysctrl". > >> +- reg: the register region of this block > >> + > >> +Examples: > >> +sysctrl: system-controller@12010000 { > >> + compatible = "hisilicon,hi3519-sysctrl", "syscon"; > >> + reg = <0x12010000 0x1000>; > >> +}; > > > > There is no requirement (nor want) for binding documents where the > > given device is simply using highly generic bindings. This just > > amounts to churn. > > > This block is specific for Hi3519 SOC, and may has its own driver.
Does it have its own driver currently?
> So I think it's better to keep this binding.
-- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog
| |