Messages in this thread | | | From | David Howells <> | Subject | Re: [PATCH] fs: dcache: Use bool return value instead of int | Date | Tue, 12 Jan 2016 00:33:37 +0000 |
| |
Al Viro <viro@ZenIV.linux.org.uk> wrote:
> > -static inline int d_unhashed(const struct dentry *dentry) > > +static inline bool d_unhashed(const struct dentry *dentry) > > { > > return hlist_bl_unhashed(&dentry->d_hash); > > } > > > > -static inline int d_unlinked(const struct dentry *dentry) > > +static inline bool d_unlinked(const struct dentry *dentry) > > { > > return d_unhashed(dentry) && !IS_ROOT(dentry); > > } > > > -static inline int simple_positive(struct dentry *dentry) > > +static inline bool simple_positive(struct dentry *dentry) > > { > > return d_really_is_positive(dentry) && !d_unhashed(dentry); > > } > > And these three are harmless, but completely pointless...
gcc-5 does actually produce slightly smaller code when int returns are replaced by bools under some circumstances within the kernel.
David
| |