lkml.org 
[lkml]   [2016]   [Jan]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH v8 3/3] x86, mce: Add __mcsafe_copy()
    On Mon, Jan 11, 2016 at 4:26 PM, Luck, Tony <tony.luck@intel.com> wrote:
    > On Fri, Jan 08, 2016 at 05:49:30PM -0800, Andy Lutomirski wrote:
    >> Also, what's the sfence for? You don't seem to be using any
    >> non-temporal operations.
    >
    > So I deleted the "sfence" and now I just have a comment
    > at the 100: label.
    >
    > 37:
    > shl $6,%ecx
    > lea -48(%ecx,%edx),%edx
    > jmp 100f
    > 38:
    > shl $6,%ecx
    > lea -56(%ecx,%edx),%edx
    > jmp 100f
    > 39:
    > lea (%rdx,%rcx,8),%rdx
    > jmp 100f
    > 40:
    > mov %ecx,%edx
    > 100:
    > /* %rax set the fault number in fixup_exception() */
    > ret
    >
    > Should I just change all the "jmp 100f" into "ret"? There
    > aren't any tools that will be confused that the function
    > has 10 returns, are there?
    >

    Given that gcc does that too, it should be fine.

    --Andy\

    \
     
     \ /
      Last update: 2016-01-12 02:01    [W:4.119 / U:0.512 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site