lkml.org 
[lkml]   [2016]   [Jan]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
SubjectRe: [PATCH] [media] netup_unidvb: Remove a useless memset
From
Date
On Sun, 2016-01-10 at 08:20 +0100, Christophe JAILLET wrote:
> This memory is allocated using kzalloc so there is no need to call
> memset(..., 0, ...)
[]
> diff --git a/drivers/media/pci/netup_unidvb/netup_unidvb_core.c b/drivers/media/pci/netup_unidvb/netup_unidvb_core.c
[]
> @@ -774,7 +774,6 @@ static int netup_unidvb_initdev(struct pci_dev *pci_dev,
>  
>   if (!ndev)
>   goto dev_alloc_err;
> - memset(ndev, 0, sizeof(*ndev));
>   ndev->old_fw = old_firmware;
>   ndev->wq = create_singlethread_workqueue(NETUP_UNIDVB_NAME);
>   if (!ndev->wq) {

It's unusual to not see the alloc above the if

Perhaps it'd be more standard to do something like:
---
diff --git a/drivers/media/pci/netup_unidvb/netup_unidvb_core.c b/drivers/media/pci/netup_unidvb/netup_unidvb_core.c
index 525ebfe..c94cecd 100644
--- a/drivers/media/pci/netup_unidvb/netup_unidvb_core.c
+++ b/drivers/media/pci/netup_unidvb/netup_unidvb_core.c
@@ -771,10 +771,9 @@ static int netup_unidvb_initdev(struct pci_dev *pci_dev,
 
  /* allocate device context */
  ndev = kzalloc(sizeof(*ndev), GFP_KERNEL);
-
  if (!ndev)
  goto dev_alloc_err;
- memset(ndev, 0, sizeof(*ndev));
+
  ndev->old_fw = old_firmware;
  ndev->wq = create_singlethread_workqueue(NETUP_UNIDVB_NAME);
  if (!ndev->wq) {

\
 
 \ /
  Last update: 2016-01-10 08:41    [W:0.051 / U:0.028 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site