lkml.org 
[lkml]   [2016]   [Jan]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH] clk: gpio: fix memory leak in of_gpio_clk_setup()
Date
Quoting Brian Norris (2015-12-16 10:28:31)
> Reported by Coverity.
>
> Fixes: f66541ba02d5 ("clk: gpio: Get parent clk names in of_gpio_clk_setup()")
> Signed-off-by: Brian Norris <computersforpeace@gmail.com>
> Cc: Jyri Sarha <jsarha@ti.com>
> Cc: Sergej Sawazki <ce3a@gmx.de>
> Cc: Stephen Boyd <sboyd@codeaurora.org>

Thanks for the fix. I already applied this one:

http://lkml.kernel.org/r/<1450852439-366-1-git-send-email-sudipm.mukherjee@gmail.com>

Regards,
Mike

> ---
> drivers/clk/clk-gpio.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/clk/clk-gpio.c b/drivers/clk/clk-gpio.c
> index 335322dc403f..c1baa89cbf91 100644
> --- a/drivers/clk/clk-gpio.c
> +++ b/drivers/clk/clk-gpio.c
> @@ -294,8 +294,10 @@ static void __init of_gpio_clk_setup(struct device_node *node,
> num_parents = of_clk_get_parent_count(node);
>
> parent_names = kcalloc(num_parents, sizeof(char *), GFP_KERNEL);
> - if (!parent_names)
> + if (!parent_names) {
> + kfree(data);
> return;
> + }
>
> for (i = 0; i < num_parents; i++)
> parent_names[i] = of_clk_get_parent_name(node, i);
> --
> 2.6.0.rc2.230.g3dd15c0
>


\
 
 \ /
  Last update: 2016-01-01 07:41    [W:3.048 / U:0.160 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site