lkml.org 
[lkml]   [2015]   [Sep]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v3] Cleanup: membarrier selftest
From
Date
On Tue, 2015-09-08 at 16:58 -0400, Mathieu Desnoyers wrote:
> We don't need to specify an explicit rule in the Makefile, the implicit
> one will do the same. The "__EXPORTED_HEADERS__" define is not needed,
> because we build the test against the installed kernel headers, not the
> in-tree kernel headers. Re-use "$(TEST_PROGS)" in the clean target
> rather than spelling the executable name twice. Include <unistd.h>
> rather than the rather specific <asm-generic/unistd.h>. Include
> <syscall.h> rather than <sys/syscall.h>. In both cases, the former
> header is located in a standard location and includes the latter.
>
> Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
> CC: Michael Ellerman <mpe@ellerman.id.au>
> CC: Andrew Morton <akpm@linux-foundation.org>
> CC: linux-api@vger.kernel.org
> CC: Pranith Kumar <bobby.prani@gmail.com>
> CC: Shuah Khan <shuahkh@osg.samsung.com>
> --
> Changes since v2:
> - Refine Changelog, removing references to comments, taking care
> of comments from Shuah Khan.
> Changes since v1:
> - Add Changelog.
> Changes since RFC:
> - Take care of comments from Michael Ellerman.

Looks great, thanks.

Acked-by: Michael Ellerman <mpe@ellerman.id.au>

cheers




\
 
 \ /
  Last update: 2015-09-09 11:01    [W:0.042 / U:0.260 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site