Messages in this thread | | | Date | Tue, 08 Sep 2015 22:40:57 -0700 (PDT) | Subject | Re: [PATCH] net: stmmac: Use msleep rather then udelay for reset delay | From | David Miller <> |
| |
From: Sjoerd Simons <sjoerd.simons@collabora.co.uk> Date: Sun, 6 Sep 2015 17:50:59 +0200
> @@ -161,11 +161,16 @@ int stmmac_mdio_reset(struct mii_bus *bus) > > if (!gpio_request(reset_gpio, "mdio-reset")) { > gpio_direction_output(reset_gpio, active_low ? 1 : 0); > - udelay(data->delays[0]); > + if (data->delays[0]) > + msleep((data->delays[0] + 999) / 1000);
Please use something like DIV_ROUND_UP(..., USEC_PER_MSEC) or similar.
| |