Messages in this thread | | | From | Chao Yu <> | Subject | RE: [PATCH RESEND] f2fs:Fix incorrect return statement in the function f2fs_ioc_release_volatile_write | Date | Tue, 08 Sep 2015 19:47:14 +0800 |
| |
> -----Original Message----- > From: Nicholas Krause [mailto:xerofoify@gmail.com] > Sent: Sunday, September 06, 2015 8:29 PM > To: jaegeuk@kernel.org > Cc: cm224.lee@samsung.com; chao2.yu@samsung.com; linux-f2fs-devel@lists.sourceforge.net; > linux-kernel@vger.kernel.org > Subject: [PATCH RESEND] f2fs:Fix incorrect return statement in the function > f2fs_ioc_release_volatile_write > > This fixes the incorrect return statement at the end of the function > f2fs_ioc_release_volatile_write's body for returning zero as this is > incorrect due to the function call before this return statement to > the function punch_hole being able to fail and we should return this > function's return fail directly in order to signal to callers of the > function f2fs_ioc_release_volatile if a failure arises with this call > to punch_hole fails. > > Signed-off-by: Nicholas Krause <xerofoify@gmail.com>
Reviewed-by: Chao Yu <chao2.yu@samsung.com>
| |