Messages in this thread | | | Subject | Re: [PATCH] usb: phy: msm: Unregister driver interest for VBUS and ID events | From | "Ivan T. Ivanov" <> | Date | Mon, 07 Sep 2015 10:56:41 +0300 |
| |
On Mon, 2015-08-24 at 10:11 -0700, Tim Bird wrote: > On 08/18/2015 12:56 AM, Ivan T. Ivanov wrote: > > Right now even if driver failed to probe extcon framework will > > still deliver its VBUS and ID events, which will lead to random > > exception codes. > > > > Fix this by removing driver interest for VBUS and ID events when > > probe fail. > > > > Fixes: 591fc116f330 ("usb: phy: msm: Use extcon framework for VBUS and ID detection") > > > > Reported-by: Tim Bird bird@sonymobile.com> > > Signed-off-by: Ivan T. Ivanov ivanov@linaro.org> > > --- > > drivers/usb/phy/phy-msm-usb.c | 26 +++++++++++++++++--------- > > 1 file changed, 17 insertions(+), 9 deletions(-) > > > > diff --git a/drivers/usb/phy/phy-msm-usb.c b/drivers/usb/phy/phy-msm-usb.c > > index 00c49bb1bd29..a9082567f114 100644 > > --- a/drivers/usb/phy/phy-msm-usb.c > > +++ b/drivers/usb/phy/phy-msm-usb.c > > @@ -1581,6 +1581,8 @@ static int msm_otg_read_dt(struct platform_device *pdev, struct msm_otg *motg) > > ret = extcon_register_interest(&motg->id.conn, ext_id->name, > > "USB-HOST", &motg->id.nb); > > if (ret < 0) { > > + if (!IS_ERR(ext_vbus)) > > + extcon_unregister_interest(&motg->vbus.conn); > > dev_err(&pdev->dev, "register ID notifier failed\n"); > > return ret; > > } > ... > > This patch is obsoleted by commit 83b7b67c7, which changes the extcon API > a bit (from register_interest to register_notifier, among other things).
Ah, sorry, missed this. New version is coming.
Regards, Ivan
| |