Messages in this thread | | | From | Alexey Brodkin <> | Subject | Re: [PATCH v2] stmmac: fix check for phydev being open | Date | Mon, 7 Sep 2015 21:26:20 +0000 |
| |
Hi Sergei,
On Tue, 2015-09-08 at 00:24 +0300, Sergei Shtylyov wrote: > On 09/07/2015 11:50 PM, Alexey Brodkin wrote: > > > Current implementation via IS_ERR(phydev) may make no sense because > > of_phy_attach() returns NULL on failure instead of error value. > > Not of_phy_connect()?
I already noticed this misspelling - it came from my exploration of what happens inside of_phy_connect(). So sort of braindump.
I will fix in v3 re-spin.
-Alexey
| |