Messages in this thread | | | Date | Mon, 7 Sep 2015 14:53:06 +0900 | From | Joonsoo Kim <> | Subject | Re: [PATCH 3/3] mm, compaction: disginguish contended status in tracepoint |
| |
On Thu, Aug 27, 2015 at 05:24:04PM +0200, Vlastimil Babka wrote: > Compaction returns prematurely with COMPACT_PARTIAL when contended or has fatal > signal pending. This is ok for the callers, but might be misleading in the > traces, as the usual reason to return COMPACT_PARTIAL is that we think the > allocation should succeed. This patch distinguishes the premature ending > condition. Further distinguishing the exact reason seems unnecessary for now.
isolate_migratepages() could return ISOLATE_ABORT and skip to call compact_finished(). trace_mm_compaction_end() will print COMPACT_PARTIAL in this case and we cannot distinguish premature ending condition. Is it okay?
Thanks.
| |