Messages in this thread | | | From | Michael Ellerman <> | Subject | Re: [v2,3/6] powerpc: kill mfvtb() | Date | Mon, 7 Sep 2015 19:29:42 +1000 (AEST) |
| |
On Mon, 2015-24-08 at 11:20:25 UTC, Kevin Hao wrote: > This function is only used by get_vtb(). They are almost the same > except the reading from the real register. Move the mfspr() to > get_vtb() and kill the function mfvtb(). With this, we can eliminate > the use of cpu_has_feature() in very core header file like reg.h. > This is a preparation for the use of jump label for cpu_has_feature().
I don't mind this change. But can you elaborate a bit on the issue with using cpu_has_feature() in reg.h? Just so I can understand the problem.
I assume you ended up in a big mess of includes when you tried to include jump_label.h from reg.h?
cheers
| |