lkml.org 
[lkml]   [2015]   [Sep]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v2] x86/asm/entry/64: Minor cleanup of conditional compilation
From
Date
On 09/05/15 13:53, Nikolay Borisov wrote:
> The entry_SYSCALL_64_fastpath was checking the value of __SYSCALL_MASK,
> which in turn was being set in arch/x86/include/asm/unistd.h depending on
> whether CONFIG_X86_X32_ABI was set or not. This made the intention a bit
> cryptic.

On the contrary: that instruction can be omitted if and only if the
value of the mask is all 1's; it doesn't matter how the mask is set. So
you just turned a local constraint into a global constraint. This is
both unnecessarily confusing and opens the risk for bugs later.

If you feel the need, you could submit a patch to add a comment, but
this version is:

Nacked-by: H. Peter Anvin <hpa@zytor.com>



\
 
 \ /
  Last update: 2015-09-06 08:21    [W:0.050 / U:0.444 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site