Messages in this thread Patch in this message | | | From | Sudip Mukherjee <> | Subject | [PATCH 2/3] staging: fbtft: do not use magic numbers | Date | Sat, 5 Sep 2015 19:13:44 +0530 |
| |
Using magic numbers are not good coding practise. Use FBTFT_GPIO_NAME_SIZE as defined in the header files.
Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org> --- drivers/staging/fbtft/fbtft_device.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/fbtft/fbtft_device.c b/drivers/staging/fbtft/fbtft_device.c index 3856c88..80ab918 100644 --- a/drivers/staging/fbtft/fbtft_device.c +++ b/drivers/staging/fbtft/fbtft_device.c @@ -1375,7 +1375,7 @@ static int __init fbtft_device_init(void) } /* name=list lists all supported displays */ - if (strncmp(name, "list", 32) == 0) { + if (strncmp(name, "list", FBTFT_GPIO_NAME_SIZE) == 0) { pr_info(DRVNAME": Supported displays:\n"); for (i = 0; i < ARRAY_SIZE(displays); i++) -- 1.9.1
| |