Messages in this thread Patch in this message | | | Date | Fri, 04 Sep 2015 10:05:14 +0200 | From | Matias Bjørling <> | Subject | Re: [PATCH v7 1/5] lightnvm: Support for Open-Channel SSDs |
| |
> > So here is a suggestion, register_bm again > if we found nvm_dev->bm == NULL in create_target(). And if it is still > NULL after that. return an error "nvm: no compatible bm was found" > and stop target creating. Otherwise, there would be a NULL Pointer > reference problem. > > That's a real problem I met in my testing and I did this change > in my local using. I hope that's useful to you. > Hi Yang,
Similar to this?
diff --git i/drivers/lightnvm/core.c w/drivers/lightnvm/core.c index 5e4c2b8..0d2e5e3 100644 --- i/drivers/lightnvm/core.c +++ w/drivers/lightnvm/core.c @@ -262,8 +262,9 @@ int nvm_init(struct nvm_dev *dev) }
if (!ret) { - pr_info("nvm: no compatible bm was found.\n"); - return 0; + pr_info("nvm: %s was not initialized due to no compatible bm.\n", + dev->name); + return -EINVAL; }
pr_info("nvm: registered %s with luns: %u blocks: %lu sector size: %d\n",
| |