lkml.org 
[lkml]   [2015]   [Sep]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3.16.y-ckt 076/130] bna: fix interrupts storm caused by erroneous packets
    Date
    3.16.7-ckt17 -stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Ivan Vecera <ivecera@redhat.com>

    commit ade4dc3e616e33c80d7e62855fe1b6f9895bc7c3 upstream.

    The commit "e29aa33 bna: Enable Multi Buffer RX" moved packets counter
    increment from the beginning of the NAPI processing loop after the check
    for erroneous packets so they are never accounted. This counter is used
    to inform firmware about number of processed completions (packets).
    As these packets are never acked the firmware fires IRQs for them again
    and again.

    Fixes: e29aa33 ("bna: Enable Multi Buffer RX")
    Signed-off-by: Ivan Vecera <ivecera@redhat.com>
    Acked-by: Rasesh Mody <rasesh.mody@qlogic.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Luis Henriques <luis.henriques@canonical.com>
    ---
    drivers/net/ethernet/brocade/bna/bnad.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/net/ethernet/brocade/bna/bnad.c b/drivers/net/ethernet/brocade/bna/bnad.c
    index 556aab75f490..04c4d4d85008 100644
    --- a/drivers/net/ethernet/brocade/bna/bnad.c
    +++ b/drivers/net/ethernet/brocade/bna/bnad.c
    @@ -674,6 +674,7 @@ bnad_cq_process(struct bnad *bnad, struct bna_ccb *ccb, int budget)
    if (!next_cmpl->valid)
    break;
    }
    + packets++;

    /* TODO: BNA_CQ_EF_LOCAL ? */
    if (unlikely(flags & (BNA_CQ_EF_MAC_ERROR |
    @@ -690,7 +691,6 @@ bnad_cq_process(struct bnad *bnad, struct bna_ccb *ccb, int budget)
    else
    bnad_cq_setup_skb_frags(rcb, skb, sop_ci, nvecs, len);

    - packets++;
    rcb->rxq->rx_packets++;
    rcb->rxq->rx_bytes += totlen;
    ccb->bytes_per_intr += totlen;

    \
     
     \ /
      Last update: 2015-09-04 15:21    [W:2.287 / U:0.392 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site