lkml.org 
[lkml]   [2015]   [Sep]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH 07/12] atm: hide 'struct zatm_t_hist'
    From
    Date
    On Wed, 2015-09-30 at 13:26 +0200, Arnd Bergmann wrote:
    > The zatm_t_hist structure is not used anywhere in the kernel, but is
    > exported to user space. As we are trying to eliminate uses of time_t
    > in the kernel for y2038 compatibility, the current definition triggers
    > checking tools because it contains 'struct timeval'.
    >
    > We can work around this by adding '#ifdef __KERNEL__'. I could not find
    > out what the structure is actually used for, so this is the safe choice
    > in case there is some user space tool that relies on the definition.
    >
    > If we are sure that nothing in user space relies on the structure, we
    > can instead remove the definition completely.

    It was used by the ZATM_GETHIST ioctl which is long since gone in the
    kernel driver. You can just remove this.



    \
     
     \ /
      Last update: 2015-09-30 17:41    [W:3.667 / U:0.076 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site