lkml.org 
[lkml]   [2015]   [Sep]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3.16.y-ckt 071/133] crypto: ghash-clmulni: specify context size for ghash async algorithm
    Date
    3.16.7-ckt18 -stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Andrey Ryabinin <aryabinin@odin.com>

    commit 71c6da846be478a61556717ef1ee1cea91f5d6a8 upstream.

    Currently context size (cra_ctxsize) doesn't specified for
    ghash_async_alg. Which means it's zero. Thus crypto_create_tfm()
    doesn't allocate needed space for ghash_async_ctx, so any
    read/write to ctx (e.g. in ghash_async_init_tfm()) is not valid.

    Signed-off-by: Andrey Ryabinin <aryabinin@odin.com>
    Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
    Signed-off-by: Luis Henriques <luis.henriques@canonical.com>
    ---
    arch/x86/crypto/ghash-clmulni-intel_glue.c | 1 +
    1 file changed, 1 insertion(+)

    diff --git a/arch/x86/crypto/ghash-clmulni-intel_glue.c b/arch/x86/crypto/ghash-clmulni-intel_glue.c
    index 8253d85aa165..de1d72e3ec59 100644
    --- a/arch/x86/crypto/ghash-clmulni-intel_glue.c
    +++ b/arch/x86/crypto/ghash-clmulni-intel_glue.c
    @@ -291,6 +291,7 @@ static struct ahash_alg ghash_async_alg = {
    .cra_name = "ghash",
    .cra_driver_name = "ghash-clmulni",
    .cra_priority = 400,
    + .cra_ctxsize = sizeof(struct ghash_async_ctx),
    .cra_flags = CRYPTO_ALG_TYPE_AHASH | CRYPTO_ALG_ASYNC,
    .cra_blocksize = GHASH_BLOCK_SIZE,
    .cra_type = &crypto_ahash_type,

    \
     
     \ /
      Last update: 2015-09-30 12:41    [W:4.158 / U:0.240 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site