lkml.org 
[lkml]   [2015]   [Sep]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] HID: hiddev: fix returned errno code in hiddev_connect()
On Wed, Sep 30, 2015 at 10:56:26AM +0100, Luis de Bethencourt wrote:
> On 30/09/15 10:52, Luis de Bethencourt wrote:
> > The driver is using -1 instead of the -ENOMEM defined macro to specify
> > that a buffer allocation failed. Since the error number is propagated,
> > the caller will get a -EPERM which is the wrong error condition.
> >
> > Also, the smatch tool complains with the following warning:
> > hiddev_connect() warn: returning -1 instead of -ENOMEM is sloppy
> >
> > Signed-off-by: Luis de Bethencourt <luisbg@osg.samsung.com>
> > ---
> > drivers/hid/usbhid/hiddev.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/hid/usbhid/hiddev.c b/drivers/hid/usbhid/hiddev.c
> > index 2f1ddca..c5290ff 100644
> > --- a/drivers/hid/usbhid/hiddev.c
> > +++ b/drivers/hid/usbhid/hiddev.c
> > @@ -894,7 +894,7 @@ int hiddev_connect(struct hid_device *hid, unsigned int force)
> > }
> >
> > if (!(hiddev = kzalloc(sizeof(struct hiddev), GFP_KERNEL)))
> > - return -1;
> > + return -ENOMEM;
> >
> > init_waitqueue_head(&hiddev->wait);
> > INIT_LIST_HEAD(&hiddev->list);
> >
>
> Hello,
>
> I got an "Undelivered Mail Returned to Sender" from Jiri Kosina's
> jikos@kernel.com email address. This email is listed multiple times
> in the MAINTAINERS file, does he have a new address to update this
> file?
Its jikos@kernel.org

regards
sudip


\
 
 \ /
  Last update: 2015-09-30 12:21    [W:0.156 / U:0.688 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site