lkml.org 
[lkml]   [2015]   [Sep]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [RFC PATCH 1/3] net: dsa: Use devm_ prefixed allocations
    From
    On Wed, Sep 30, 2015 at 5:21 AM, Neil Armstrong <narmstrong@baylibre.com> wrote:
    > To simplify and prevent memory leakage when unbinding, use
    > the devm_ memory allocation calls.
    >
    > Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
    > ---
    > net/dsa/dsa.c | 6 +++---
    > 1 file changed, 3 insertions(+), 3 deletions(-)
    >
    > diff --git a/net/dsa/dsa.c b/net/dsa/dsa.c
    > index c59fa5d..98f94c2 100644
    > --- a/net/dsa/dsa.c
    > +++ b/net/dsa/dsa.c
    > @@ -305,7 +305,7 @@ static int dsa_switch_setup_one(struct dsa_switch *ds, struct device *parent)
    > if (ret < 0)
    > goto out;
    >
    > - ds->slave_mii_bus = mdiobus_alloc();
    > + ds->slave_mii_bus = devm_mdiobus_alloc(parent);
    > if (ds->slave_mii_bus == NULL) {
    > ret = -ENOMEM;
    > goto out;
    > @@ -400,7 +400,7 @@ dsa_switch_setup(struct dsa_switch_tree *dst, int index,
    > /*
    > * Allocate and initialise switch state.
    > */
    > - ds = kzalloc(sizeof(*ds) + drv->priv_size, GFP_KERNEL);
    > + ds = devm_kzalloc(parent, sizeof(*ds) + drv->priv_size, GFP_KERNEL);

    Shouldn't devm_ functions be called only from probe and remove functions?


    \
     
     \ /
      Last update: 2015-09-30 23:41    [W:5.065 / U:0.024 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site