Messages in this thread | | | Date | Wed, 30 Sep 2015 14:14:38 -0700 (PDT) | From | David Rientjes <> | Subject | Re: [PATCH -mm v2 1/3] mm/oom_kill: remove the wrong fatal_signal_pending() check in oom_kill_process() |
| |
On Wed, 30 Sep 2015, Oleg Nesterov wrote:
> The fatal_signal_pending() was added to suppress unnecessary "sharing > same memory" message, but it can't 100% help anyway because it can be > false-negative; SIGKILL can be already dequeued. > > And worse, it can be false-positive due to exec or coredump. exec is > mostly fine, but coredump is not. It is possible that the group leader > has the pending SIGKILL because its sub-thread originated the coredump, > in this case we must not skip this process. > > We could probably add the additional ->group_exit_task check but this > pach just removes the wrong check along with pr_info(). > > Signed-off-by: Oleg Nesterov <oleg@redhat.com>
Acked-by: David Rientjes <rientjes@google.com>
| |