Messages in this thread | | | Subject | Re: [RFC PATCH 2/3] clocksource: mtk_timer: change pr_warn()s to pr_err()s in mtk_timer_init | From | Joe Perches <> | Date | Thu, 03 Sep 2015 20:40:06 -0700 |
| |
On Fri, 2015-09-04 at 06:21 +0300, Alexey Klimov wrote: > These messages are actually errors and not warnings. > Use pr_err() macro for them and add missing \n. [] > diff --git a/drivers/clocksource/mtk_timer.c b/drivers/clocksource/mtk_timer.c [] > @@ -184,7 +184,7 @@ static void __init mtk_timer_init(struct device_node *node) > > evt = kzalloc(sizeof(*evt), GFP_KERNEL); > if (!evt) { > - pr_warn("Can't allocate mtk clock event driver struct"); > + pr_err("Can't allocate mtk clock event driver struct\n"); > return; > }
Might as well remove this one as there's a generic stack_dump() on alloc failures.
| |