lkml.org 
[lkml]   [2015]   [Sep]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCHv7] ARM: exynos_defconfig: Enable LEDS for Odroid-XU3/XU4
From
Date
On 04.09.2015 03:11, Anand Moon wrote:
> Earlier design of the LED for Odroid XU3 was using gpio-leds
> Now It was change to using both pwm-leds and gpio-leds.

It is still not a reason for this change. gpio-leds were not enabled
before. This could be a valid reason of adding LEDS_PWM to existing
config LEDS_GPIO. But LEDS_GPIO were not enabled... so why the change on
the board from gpio->(gpio+pwm) means that we have to enable LEDS_GPIO?

Actually I gave up on this and I wanted to change the commit message on
myself when applying. But discussion was brought up again so... clearly
we have different understanding of the meaning of "WHY". :)

Best regards,
Krzysztof

>
> Signed-off-by: Anand Moon <linux.amoon@gmail.com>
> Reviewed-by: Javier Martinez Canillas <javier@osg.samsung.com>
>
> ---
> Changes from last version
> dropped following option.
> CONFIG_LEDS_CLASS_FLASH
> CONFIG_TRIGGER_ONESHOT
> CONFIG_LEDS_TRIGGER_TIMER
> CONFIG_TRIGGER_GPIO
> fixed the From address
> fixed the commit message.
> ---
> arch/arm/configs/exynos_defconfig | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/arch/arm/configs/exynos_defconfig b/arch/arm/configs/exynos_defconfig
> index 9504e77..bd6b7f7 100644
> --- a/arch/arm/configs/exynos_defconfig
> +++ b/arch/arm/configs/exynos_defconfig
> @@ -163,6 +163,12 @@ CONFIG_MMC_SDHCI_S3C_DMA=y
> CONFIG_MMC_DW=y
> CONFIG_MMC_DW_IDMAC=y
> CONFIG_MMC_DW_EXYNOS=y
> +CONFIG_NEW_LEDS=y
> +CONFIG_LEDS_CLASS=y
> +CONFIG_LEDS_GPIO=y
> +CONFIG_LEDS_PWM=y
> +CONFIG_LEDS_TRIGGERS=y
> +CONFIG_LEDS_TRIGGER_HEARTBEAT=y
> CONFIG_RTC_CLASS=y
> CONFIG_RTC_DRV_MAX77686=y
> CONFIG_RTC_DRV_MAX77802=y
>



\
 
 \ /
  Last update: 2015-09-04 02:01    [W:0.090 / U:1.188 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site