Messages in this thread | | | Date | Thu, 3 Sep 2015 14:19:01 -0700 | From | Kenneth Westfield <> | Subject | Re: [alsa-devel] [PATCH 1/2] ASoC: qcom: change PTR_ERR argument |
| |
On Sun, Aug 30, 2015 at 11:05:10AM -0700, Julia Lawall wrote: > Apply PTR_ERR to the value that was recently assigned. > > The semantic match that finds this problem is as follows: > (http://coccinelle.lip6.fr/) > > // <smpl> > @@ > expression x,y; > @@ > > if (IS_ERR(x) || ...) { > ... when any > when != IS_ERR(...) > ( > PTR_ERR(x) > | > * PTR_ERR(y) > ) > ... when any > } > // </smpl> > > Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr> > > ---
The patch itself looks good. Thanks.
Acked-by: Kenneth Westfield <kwestfie@codeaurora.org>
-- Kenneth Westfield Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project
| |