[lkml]   [2015]   [Sep]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH] crypto/testmgr: don't copy from source IV too much
On Thu, Sep 03, 2015 at 02:32:00PM +0300, Andrey Ryabinin wrote:
> While the destination buffer 'iv' is MAX_IVLEN size,
> the source 'template[i].iv' could be smaller. Thus
> copying it via memcpy() leads to invalid memory access.
> Use strlcpy() instead.
> Signed-off-by: Andrey Ryabinin <>

Thanks for the patch. Unfortunately it's broken because the IV
is not a string and can contain NULs. So either fix it by using
the real ivsize, or change template[i].iv to a char array.

Email: Herbert Xu <>
Home Page:
PGP Key:

 \ /
  Last update: 2015-09-03 15:41    [W:0.101 / U:7.288 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site