lkml.org 
[lkml]   [2015]   [Sep]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH] thermal: avoid division by zero in power allocator
    Date
    During boot I get a div by zero Oops regression starting in v4.3-rc3.

    Reviewed-by: Javi Merino <javi.merino@arm.com>
    Signed-off-by: Andrea Arcangeli <aarcange@redhat.com>
    ---
    drivers/thermal/power_allocator.c | 10 ++++++++++
    1 file changed, 10 insertions(+)

    diff --git a/drivers/thermal/power_allocator.c b/drivers/thermal/power_allocator.c
    index 7ff9627..e570ff0 100644
    --- a/drivers/thermal/power_allocator.c
    +++ b/drivers/thermal/power_allocator.c
    @@ -144,6 +144,16 @@ static void estimate_pid_constants(struct thermal_zone_device *tz,
    switch_on_temp = 0;

    temperature_threshold = control_temp - switch_on_temp;
    + /*
    + * estimate_pid_constants() tries to find appropriate default
    + * values for thermal zones that don't provide them. If a
    + * system integrator has configured a thermal zone with two
    + * passive trip points at the same temperature, that person
    + * hasn't put any effort to set up the thermal zone properly
    + * so just give up.
    + */
    + if (!temperature_threshold)
    + return;

    if (!tz->tzp->k_po || force)
    tz->tzp->k_po = int_to_frac(sustainable_power) /

    \
     
     \ /
      Last update: 2015-09-28 23:41    [W:3.238 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site