lkml.org 
[lkml]   [2015]   [Sep]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH 1/3] Thermal: initialize thermal zone device correctly
Date
Hi, Javi,

> -----Original Message-----
> From: Javi Merino [mailto:javi.merino@arm.com]
> Sent: Monday, September 28, 2015 10:28 PM
> To: Chen, Yu C
> Cc: linux-pm@vger.kernel.org; edubezval@gmail.com; Zhang, Rui; linux-
> kernel@vger.kernel.org; stable@vger.kernel.org
> Subject: Re: [PATCH 1/3] Thermal: initialize thermal zone device correctly
>
> On Sun, Sep 27, 2015 at 06:48:28AM +0100, Chen Yu wrote:
> > From: Zhang Rui <rui.zhang@intel.com>
> >
> > After thermal zone device registered, as we have not read any
> > temperature before, thus tz->temperature should not be 0, which
> > actually means 0C, and thermal trend is not available.
> > In this case, we need specially handling for the first
> > thermal_zone_device_update().
> >
> > Both thermal core framework and step_wise governor is enhanced to
> > handle this.
>
> It may be worth pointing out that the step_wise governor is the only one
> that uses trends, so it's the only thermal governor that needs to be updated.
>
OK, will add.
>
> > - if (old_target == instance->target)
> > + if (instance->initialized &&
> > + old_target == instance->target)
>
> nit: it fits in one line,
>
> if (instance->initialized && old_target == instance->target)
>
> is 77 characters.
>
Not sure if the limit for one line is 75 in checkpatch.pl, I'll have a try.
Thanks!

Best Regards,
Yu
\
 
 \ /
  Last update: 2015-09-28 19:41    [W:0.055 / U:0.448 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site