Messages in this thread | | | Date | Sun, 27 Sep 2015 17:49:22 -0700 | From | Brian Norris <> | Subject | Re: [PATCH v2] mtd: nand: pxa3xx-nand: switch to dmaengine |
| |
On Sun, Sep 27, 2015 at 05:18:56PM -0700, Brian Norris wrote: > Sparse has one complaint, but I have no others: > > On Sun, Sep 06, 2015 at 03:12:47PM +0200, Robert Jarzmik wrote: > > diff --git a/drivers/mtd/nand/pxa3xx_nand.c b/drivers/mtd/nand/pxa3xx_nand.c > > index 2f39bfe34584..1e9d462065e8 100644 > > --- a/drivers/mtd/nand/pxa3xx_nand.c > > +++ b/drivers/mtd/nand/pxa3xx_nand.c > > @@ -15,7 +15,9 @@ > ... > > @@ -564,57 +567,61 @@ static void handle_data_pio(struct pxa3xx_nand_info *info) > [...] > > +static void start_data_dma(struct pxa3xx_nand_info *info) > > +{ > > + enum dma_data_direction direction; > > I think this should be dma_transfer_direction. See warning below.
I just fixed this up and pushed to l2-mtd.git. I can revert and apply something different if you'd like.
Regards, Brian
| |