lkml.org 
[lkml]   [2015]   [Sep]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.2 057/134] powerpc/pseries: Release DRC when configure_connector fails
    Date
    4.2-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Bharata B Rao <bharata@linux.vnet.ibm.com>

    commit daebaabb5cfbe4a6f09ca0e0f8b7673efc704960 upstream.

    Commit f32393c943e2 ("powerpc/pseries: Correct cpu affinity for
    dlpar added cpus") moved dlpar_acquire_drc() call to before
    dlpar_configure_connector() call in dlpar_cpu_probe(), but missed
    to release the DRC if dlpar_configure_connector() failed.
    During CPU hotplug, if configure-connector fails for any reason,
    then this will result in subsequent CPU hotplug attempts to fail.

    Release the acquired DRC if dlpar_configure_connector() call fails
    so that the DRC is left in right isolation and allocation state
    for the subsequent hotplug operation to succeed.

    Fixes: f32393c943e2 ("powerpc/pseries: Correct cpu affinity for dlpar added cpus")
    Signed-off-by: Bharata B Rao <bharata@linux.vnet.ibm.com>
    Reviewed-by: Nathan Fontenot <nfont@linux.vnet.ibm.com>
    Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    arch/powerpc/platforms/pseries/dlpar.c | 4 +++-
    1 file changed, 3 insertions(+), 1 deletion(-)

    --- a/arch/powerpc/platforms/pseries/dlpar.c
    +++ b/arch/powerpc/platforms/pseries/dlpar.c
    @@ -422,8 +422,10 @@ static ssize_t dlpar_cpu_probe(const cha

    dn = dlpar_configure_connector(cpu_to_be32(drc_index), parent);
    of_node_put(parent);
    - if (!dn)
    + if (!dn) {
    + dlpar_release_drc(drc_index);
    return -EINVAL;
    + }

    rc = dlpar_attach_node(dn);
    if (rc) {



    \
     
     \ /
      Last update: 2015-09-27 00:21    [W:4.043 / U:0.180 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site