lkml.org 
[lkml]   [2015]   [Sep]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.2 128/134] IB/mlx4: Forbid using sysfs to change RoCE pkeys
    Date
    4.2-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Jack Morgenstein <jackm@dev.mellanox.co.il>

    commit 2b135db3e81301d0452e6aa107349abe67b097d6 upstream.

    The pkey mapping for RoCE must remain the default mapping:
    VFs:
    virtual index 0 = mapped to real index 0 (0xFFFF)
    All others indices: mapped to a real pkey index containing an
    invalid pkey.
    PF:
    virtual index i = real index i.

    Don't allow users to change these mappings using files found in
    sysfs.

    Fixes: c1e7e466120b ('IB/mlx4: Add iov directory in sysfs under the ib device')
    Signed-off-by: Jack Morgenstein <jackm@dev.mellanox.co.il>
    Signed-off-by: Or Gerlitz <ogerlitz@mellanox.com>
    Signed-off-by: Doug Ledford <dledford@redhat.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/infiniband/hw/mlx4/sysfs.c | 5 ++++-
    1 file changed, 4 insertions(+), 1 deletion(-)

    --- a/drivers/infiniband/hw/mlx4/sysfs.c
    +++ b/drivers/infiniband/hw/mlx4/sysfs.c
    @@ -640,6 +640,8 @@ static int add_port(struct mlx4_ib_dev *
    struct mlx4_port *p;
    int i;
    int ret;
    + int is_eth = rdma_port_get_link_layer(&dev->ib_dev, port_num) ==
    + IB_LINK_LAYER_ETHERNET;

    p = kzalloc(sizeof *p, GFP_KERNEL);
    if (!p)
    @@ -657,7 +659,8 @@ static int add_port(struct mlx4_ib_dev *

    p->pkey_group.name = "pkey_idx";
    p->pkey_group.attrs =
    - alloc_group_attrs(show_port_pkey, store_port_pkey,
    + alloc_group_attrs(show_port_pkey,
    + is_eth ? NULL : store_port_pkey,
    dev->dev->caps.pkey_table_len[port_num]);
    if (!p->pkey_group.attrs) {
    ret = -ENOMEM;



    \
     
     \ /
      Last update: 2015-09-27 00:21    [W:4.179 / U:0.120 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site