Messages in this thread | | | Date | Sat, 26 Sep 2015 15:52:45 -0400 | From | Tejun Heo <> | Subject | Re: netlink: Add netlink_bound helper and use it in netlink_getname |
| |
Hello,
On Sun, Sep 27, 2015 at 03:49:16AM +0800, Herbert Xu wrote: > If the autobind is not complete then netlink_getname must return > zero rather than some garbage portid that belongs to somebody > else's socket. That's what we did before any of this lockless > code was introduced. > > If you don't check nlk->bound then you may return garbage.
Ah, yeah, you're right. We need to check that there because it may contain a garbage value. I still think it'd better to use netlink_bound() test in connect() too tho.
Thanks.
-- tejun
| |