lkml.org 
[lkml]   [2015]   [Sep]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] kselftest: using built-in rule when delete file
On Thu, Sep 24, 2015 at 12:07:47PM +1000, Michael Ellerman wrote:
> On Thu, 2015-09-24 at 10:05 +0800, long.wanglong wrote:
> > On 2015/9/24 9:46, Michael Ellerman wrote:
> > > On Wed, 2015-09-23 at 09:40 +0000, Wang Long wrote:
> > >> Use make's built-in rules to when delete a file
> > >> or delete files.
> > >
> > > It's not a built-in rule, it's a variable.
> >
> > Sorry,I did not describe clearly. It is a variable used as
> > name of program in built-in rules.
> >
> > > Personally I think using rm directly is clearer, but I guess this is fine. Do
> > > you actually want to override $RM ?
> >
> > So far, I do not want to override $(RM). But I found that some test's Makefile
> > using *$(RM)* while the other's using *rm -f*, I think it is better to use one
> > of them in all unit tests.

Agreed, consistency is good.

> >
> > Do you think which one is better?
>
> I prefer just using rm -f, because it's less magic, everyone knows what it does.
>

Also agreed, it's explicit and perfectly functional.

--
Darren Hart
Intel Open Source Technology Center


\
 
 \ /
  Last update: 2015-09-25 18:01    [W:0.055 / U:6.420 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site