lkml.org 
[lkml]   [2015]   [Sep]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 4/6] extcon: arizona: Add device binding for second jack detect pin on GPIO5
On Fri, Sep 25, 2015 at 09:54:26AM +0900, Chanwoo Choi wrote:
> Hi Charles,
>
> I have one comment.
> I think current extcon-arizona.c has the many platform data
> so, extcon-arizona.c use the too much if statement to support each feature
> for different wolfsonmicro codec. I think it cause the complicated code.
>
> For example,
> You may use 'struct of_device_id' as following. You used already this method
> on drivers/mfd/arizona-core.c. If you separate the function of each wmXXXX arizona,
> it makes improved readability for extcon-arizona.c and some user will use extcon-arizora
> more easily.
>
> struct arizona_extcon_data {
> void (*init)(...);
> void (*irq_handler)(...);
> ...
> };
>
> struct arizona_extcon_data wm8994_data {
> .init = wm8994_extcon_init,
> .irq_handler = wm8994_extcon_irq_handler;
> ...
> };
>
> static const struct of_device_id arizona_extcon_dt_match[] = {
> {
> .compatible = "wm8994-arizona-extcon",
> .data = (void *)wm8994_data;
> }, {
> .compatible = "wmXXXX-arizona-extcon",
> .data = (void *)wmXXXX_data;
> },
> };
>
> I expect that you will revise the arizona-extcon.c driver on next time.

I will have an investigation to see what ideas I can come up with
here and send through some patches.

But I am slightly worried you think the gains will be better than
they actually will be. Most of the platform data is just that
platform data, and needs to be configured based on the system not
based on the CODEC.

Thanks,
Charles


\
 
 \ /
  Last update: 2015-09-25 12:01    [W:0.085 / U:2.936 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site