lkml.org 
[lkml]   [2015]   [Sep]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH 12/15] mm, dax, gpu: convert vm_insert_mixed to __pfn_t, introduce _PAGE_DEVMAP
    From
    Hi Dan,

    On Wed, Sep 23, 2015 at 6:42 AM, Dan Williams <dan.j.williams@intel.com> wrote:
    > Convert the raw unsigned long 'pfn' argument to __pfn_t for the purpose of
    > evaluating the PFN_MAP and PFN_DEV flags. When both are set the it

    s/the it/it/

    > triggers _PAGE_DEVMAP to be set in the resulting pte. This flag will
    > later be used in the get_user_pages() path to pin the page mapping,
    > dynamically allocated by devm_memremap_pages(), until all the resulting
    > pages are released.
    >
    > There are no functional changes to the gpu drivers as a result of this
    > conversion.
    >
    > This uncovered several architectures with no local definition for
    > pfn_pte(), in response __pfn_t_pte() is only defined when an arch
    > opts-in by "#define pfn_pte pfn_pte".
    >
    > Cc: Dave Hansen <dave@sr71.net>
    > Cc: Andrew Morton <akpm@linux-foundation.org>
    > Cc: David Airlie <airlied@linux.ie>
    > Signed-off-by: Dan Williams <dan.j.williams@intel.com>

    > diff --git a/arch/m68k/include/asm/page_no.h b/arch/m68k/include/asm/page_no.h
    > index ef209169579a..930a42f6db44 100644
    > --- a/arch/m68k/include/asm/page_no.h
    > +++ b/arch/m68k/include/asm/page_no.h
    > @@ -34,6 +34,7 @@ extern unsigned long memory_end;
    >
    > #define virt_addr_valid(kaddr) (((void *)(kaddr) >= (void *)PAGE_OFFSET) && \
    > ((void *)(kaddr) < (void *)memory_end))
    > +#define __pfn_to_phys(pfn) PFN_PHYS(pfn)

    The above change doesn't match the patch description?

    Gr{oetje,eeting}s,

    Geert

    --
    Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

    In personal conversations with technical people, I call myself a hacker. But
    when I'm talking to journalists I just say "programmer" or something like that.
    -- Linus Torvalds


    \
     
     \ /
      Last update: 2015-09-23 16:01    [W:4.159 / U:0.096 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site