Messages in this thread | | | Subject | Re: [PATCH v1 8/8] pwm-pca9685: enable ACPI device found on Galileo Gen2 | From | Andy Shevchenko <> | Date | Wed, 23 Sep 2015 15:56:52 +0300 |
| |
On Wed, 2015-09-23 at 14:48 +0200, Thierry Reding wrote: > > > >
> On Wed, Sep 23, 2015 at 11:41:26AM +0300, Andy Shevchenko wrote: > > On Tue, 2015-09-22 at 16:37 +0200, Thierry Reding wrote: > > > On Tue, Sep 22, 2015 at 01:10:19PM +0300, Andy Shevchenko wrote: > >
> > > > > > > .of_match_table = pca9685_dt_ids, > > > > > > Similarly to the above, this should use of_match_ptr(), which in > > > turn > > > will require #ifdef protection for the table to avoid warnings. > > > > Hmm... my patch do not touches that part. Perhaps another patch for > > this? > > Your patch does touch that part by removing the dependency on OF. > That > makes it possible to build this code with !OF, which in turn would > make > the OF match table unused.
Ah, you're right. Will amend this part as well. Thanks!
> > Thierry
-- Andy Shevchenko <andriy.shevchenko@linux.intel.com> Intel Finland Oy
| |