Messages in this thread | | | Date | Wed, 23 Sep 2015 10:47:49 +0200 | From | David Sterba <> | Subject | Re: [PATCH 1/2] btrfs: check-integrity: Fix returned errno codes |
| |
On Tue, Sep 22, 2015 at 05:29:38PM +0100, Luis de Bethencourt wrote: > check-integrity is using -1 instead of the -ENOMEM defined macro to > specify that a buffer allocation failed. Since the error number is > propagated, the caller will get a -EPERM which is the wrong error > condition.
Agreed. btrfsic_process_superblock can be called from the mount path so getting EPERM would be confusing.
> Also, the smatch tool complains with the following warnings: > btrfsic_process_superblock() warn: returning -1 instead of -ENOMEM is sloppy > btrfsic_read_block() warn: returning -1 instead of -ENOMEM is sloppy > > Signed-off-by: Luis de Bethencourt <luisbg@osg.samsung.com>
Reviewed-by: David Sterba <dsterba@suse.com>
| |