lkml.org 
[lkml]   [2015]   [Sep]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3.19.y-ckt 023/102] hwrng: core - correct error check of kthread_run call
    Date
    3.19.8-ckt7 -stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Martin Schwidefsky <schwidefsky@de.ibm.com>

    commit 17fb874dee093139923af8ed36061faa92cc8e79 upstream.

    The kthread_run() function can return two different error values
    but the hwrng core only checks for -ENOMEM. If the other error
    value -EINTR is returned it is assigned to hwrng_fill and later
    used on a kthread_stop() call which naturally crashes.

    Signed-off-by: Martin Schwidefsky <schwidefsky@de.ibm.com>
    Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
    Signed-off-by: Kamal Mostafa <kamal@canonical.com>
    ---
    drivers/char/hw_random/core.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/char/hw_random/core.c b/drivers/char/hw_random/core.c
    index 1500cfd..b98fb25 100644
    --- a/drivers/char/hw_random/core.c
    +++ b/drivers/char/hw_random/core.c
    @@ -361,7 +361,7 @@ static int hwrng_fillfn(void *unused)
    static void start_khwrngd(void)
    {
    hwrng_fill = kthread_run(hwrng_fillfn, NULL, "hwrng");
    - if (hwrng_fill == ERR_PTR(-ENOMEM)) {
    + if (IS_ERR(hwrng_fill)) {
    pr_err("hwrng_fill thread creation failed");
    hwrng_fill = NULL;
    }
    --
    1.9.1


    \
     
     \ /
      Last update: 2015-09-22 20:41    [W:3.697 / U:0.064 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site