Messages in this thread | | | Date | Tue, 22 Sep 2015 09:39:22 -0700 | From | "Paul E. McKenney" <> | Subject | Re: crisv32 runtime failure in -next due to 'page-flags: define behavior SL*B-related flags on compound pages' |
| |
On Tue, Sep 22, 2015 at 06:16:18PM +0200, Hans-Peter Nilsson wrote: > > From: "Kirill A. Shutemov" <kirill@shutemov.name> > > Date: Tue, 22 Sep 2015 17:31:04 +0200 > > > On Tue, Sep 22, 2015 at 08:18:35AM -0700, Paul E. McKenney wrote: > > > On Tue, Sep 22, 2015 at 03:57:06PM +0200, Hans-Peter Nilsson wrote: > > > > I guess you hit the right spot, but I'd think people would be > > > > more comfortable with aligning to sizeof (void *). > > > > > > I would indeed prefer sizeof(void *). > > > > Do you prefer to have the attribute set for whole structure or for ->next? > > I think attribute on ->next is more appropriate from documentation POV. > > Speaking of the documentation POV, I'd recommend adding an > explanatory comment. Here's hoping this was obvious! ;)
What Hans-Peter said! ;-)
Thanx, Paul
| |