lkml.org 
[lkml]   [2015]   [Sep]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] net: dsa: Fix Marvell Egress Trailer check
From
Date
On 09/22/2015 02:28 AM, Neil Armstrong wrote:
> The Marvell Egress rx trailer check must be fixed to
> correctly detect bad bits in the third byte of the
> Eggress trailer as described in the Table 28 of the
> 88E6060 datasheet.
> The current code incorrectly omits to check the third
> byte and checks the fourth byte twice.
>
> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>

Nice catch.

Acked-by: Guenter Roeck <linux@roeck-us.net>

> ---
> net/dsa/tag_trailer.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/dsa/tag_trailer.c b/net/dsa/tag_trailer.c
> index e268f9d..d0526a9 100644
> --- a/net/dsa/tag_trailer.c
> +++ b/net/dsa/tag_trailer.c
> @@ -84,7 +84,7 @@ static int trailer_rcv(struct sk_buff *skb, struct net_device *dev,
>
> trailer = skb_tail_pointer(skb) - 4;
> if (trailer[0] != 0x80 || (trailer[1] & 0xf8) != 0x00 ||
> - (trailer[3] & 0xef) != 0x00 || trailer[3] != 0x00)
> + (trailer[2] & 0xef) != 0x00 || trailer[3] != 0x00)
> goto out_drop;
>
> source_port = trailer[1] & 7;
>



\
 
 \ /
  Last update: 2015-09-22 17:21    [W:2.055 / U:0.668 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site