lkml.org 
[lkml]   [2015]   [Sep]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 5/8] tools build: Allow setting the feature detection user
Em Tue, Sep 22, 2015 at 10:02:42AM -0300, Arnaldo Carvalho de Melo escreveu:
> Em Tue, Sep 22, 2015 at 08:51:00AM +0200, Jiri Olsa escreveu:
> > On Mon, Sep 21, 2015 at 06:23:18PM -0300, Arnaldo Carvalho de Melo wrote:
> > one nit ;-)
>
> Good, at first I thought the mistake was more embarassing, like
> forgetting one real use of that file... Fixing it, thanks!

> > +++ b/tools/build/Makefile.feature
> > @@ -132,7 +132,7 @@ endif
> > # The $(feature_display) controls the default detection message
> > # output. It's set if:
> > # - detected features differes from stored features from
> > -# last build (in FEATURE-DUMP file)
> > +# last build (in FEATURE-DUMP$(FEATURE_USER) file)
> > # - one of the $(FEATURE_DISPLAY) is not detected

I changed it to:

# The $(feature_display) controls the default detection message
# output. It's set if:
# - detected features differes from stored features from
-# last build (in FEATURE-DUMP file)
+# last build (in $(FEATURE_DUMP_FILENAME) file)
# - one of the $(FEATURE_DISPLAY) is not detected

So that we take $(OUTPUT) into account as well :-)

- Arnaldo


\
 
 \ /
  Last update: 2015-09-22 15:21    [W:1.522 / U:0.248 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site