Messages in this thread Patch in this message | | | Date | Mon, 21 Sep 2015 21:23:47 +0100 | From | Jonathan McDowell <> | Subject | [PATCH] Re: [4.3-rc1 regression] modular 8250 doesn't load |
| |
In article <20150914211827.GA3440@kroah.com> (earth.lists.linux-kernel) you wrote: > On Mon, Sep 14, 2015 at 02:12:43PM -0700, Greg Kroah-Hartman wrote: > > On Mon, Sep 14, 2015 at 10:42:24PM +0200, Mikael Pettersson wrote: > > > Greg Kroah-Hartman writes: uart_insert_char is EXPORT_SYMBOL_GPL, > > > so could the missing license tag be preventing 8250_core from > > > binding to it? (I haven't checked the other symbols but I assume > > > they are also _GPL.) > > > > Ah, crap, yes, you are right. You can test this with a simple: > > MODULE_LICENSE("GPL"); line added to the 8250_base file.
> Wait, 8250_base.c has a module license line.
8250_base.c doesn't exist; it is built from 8250_port.c and 8250_dma.c, neither of which have a MODULE_LICENSE line. Adding MODULE_LICENSE("GPL") as per below fixes the issue for me (on 4.3-rc2):
----- Author: Jonathan McDowell <noodles@earth.li> Date: Mon Sep 21 21:20:53 2015 +0100
Add missing module license for 8250_base.ko The split of the 8250 driver into a 8250_base/8250.ko resulted in a lack of a license for the 8250_base.ko module. This caused the module to fail to load and the kernel to be tainted. Add the appropriate MODULE_LICENSE to 8250_port.c, which is always compiled into 8250_base.ko Signed-off-by: Jonathan McDowell <noodles@earth.li>
diff --git a/drivers/tty/serial/8250/8250_port.c b/drivers/tty/serial/8250/8250_port.c index 54e6c8d..b1e0ba3 100644 --- a/drivers/tty/serial/8250/8250_port.c +++ b/drivers/tty/serial/8250/8250_port.c @@ -2910,3 +2910,5 @@ int serial8250_console_setup(struct uart_port *port, char *options, bool probe) } #endif /* CONFIG_SERIAL_8250_CONSOLE */ + +MODULE_LICENSE("GPL"); ----- J.
-- Even the Evening Herald slags me off. This .sig brought to you by the letter U and the number 21 Product of the Republic of HuggieTag
| |