Messages in this thread | | | Subject | Re: [PATCH 2/3] mfd: tps65912: Rewrite driver adding DT support and using regmap | From | "Andrew F. Davis" <> | Date | Mon, 21 Sep 2015 14:59:59 -0500 |
| |
On 09/21/2015 02:54 PM, Mark Brown wrote: > On Mon, Sep 21, 2015 at 02:46:50PM -0500, Andrew F. Davis wrote: >> On 09/21/2015 02:26 PM, Mark Brown wrote: > >>> So split that interface change between the MFD and the function drivers >>> out into a separate change - you've got way more than just an interface >>> change in here (and you've not enumerated the various things that are >>> being changed in the changelog). > >> I'm not really "changing" anything, this is a ground-up re-write. This >> fundamentally changes the way the MFD core and the function drivers interact, >> I would consider this a whole new driver that just happens to replace an older >> driver, not a bunch of incremental changes although I kept the same filenames. > > So split out the deletion then add the new driver like you'd add any > other new driver. If there were in tree users even that would be really > problematic but it does seem like we don't have any so perhaps people > will be OK with this. >
OK, I'll split that in v2.
| |