Messages in this thread | | | Subject | Re: [PATCH 09/14] RFC: usb/host/fotg210: Add function: output_buf_tds_dir() | From | Sergei Shtylyov <> | Date | Mon, 21 Sep 2015 22:15:21 +0300 |
| |
On 09/21/2015 06:01 PM, Peter Senna Tschudin wrote:
> checkpatch complains about too many leading tabs because the switch > statement starts after 6 tabs. > > fill_periodic_buffer() -> for() -> do -> switch() -> if() -> > list_for_each_entry() and finally the last switch(). > > This patch moves the list_for_each_entry() and the last switch() to a > new inline function named output_buf_tds_dir(). This change makes the > code easier to read and calm down checkpatch. This patch changes it to: > > fill_periodic_buffer() -> for() -> do -> switch() -> if() -> > output_buf_tds_dir() > > Signed-off-by: Peter Senna Tschudin <peter.senna@gmail.com> > --- > drivers/usb/host/fotg210-hcd.c | 64 ++++++++++++++++++++++-------------------- > 1 file changed, 33 insertions(+), 31 deletions(-) > > diff --git a/drivers/usb/host/fotg210-hcd.c b/drivers/usb/host/fotg210-hcd.c > index 82cd5da..13cca41 100644 > --- a/drivers/usb/host/fotg210-hcd.c > +++ b/drivers/usb/host/fotg210-hcd.c > @@ -497,6 +497,36 @@ static ssize_t fill_async_buffer(struct debug_buffer *buf) > return strlen(buf->output_buf); > } > > +/* count tds, get ep direction */ > +static inline unsigned output_buf_tds_dir(char *buf,
Please drop *inline*, let gcc figure it out.
> + struct fotg210_hcd *fotg210, > + struct fotg210_qh_hw *hw, > + struct fotg210_qh *qh, unsigned size) > +{ > + u32 scratch = hc32_to_cpup(fotg210, &hw->hw_info1); > + struct fotg210_qtd *qtd; > + char *type = ""; > + unsigned temp = 0; > + > + /* count tds, get ep direction */ > + list_for_each_entry(qtd, &qh->qtd_list, qtd_list) { > + temp++; > + switch (0x03 & (hc32_to_cpu(fotg210, qtd->hw_token) >> 8)) {
I think the preference is to place immediate value after &.
> + case 0: > + type = "out"; > + continue; > + case 1: > + type = "in"; > + continue; > + } > + } > + > + return scnprintf(buf, size, "(%c%d ep%d%s [%d/%d] q%d p%d)", > + speed_char(scratch), scratch & 0x007f, > + (scratch >> 8) & 0x000f, type, qh->usecs, > + qh->c_usecs, temp, 0x7ff & (scratch >> 16));
Likewise.
[...]
MBR, Sergei
| |