lkml.org 
[lkml]   [2015]   [Sep]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH 11/17] pm: bf609: remove misuse of IRQF_NO_SUSPEND flag
Date
The IRQF_NO_SUSPEND flag is used to identify the interrupts that should
be left enabled so as to allow them to work as expected during the
suspend-resume cycle, but doesn't guarantee that it will wake the system
from a suspended state, enable_irq_wake is recommended to be used for
the wakeup.

This patch removes the use of IRQF_NO_SUSPEND flags replacing it with
enable_irq_wake instead.

Cc: Steven Miao <realmz6@gmail.com>
Cc: adi-buildroot-devel@lists.sourceforge.net
Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
---
arch/blackfin/mach-bf609/pm.c | 13 +++++++------
1 file changed, 7 insertions(+), 6 deletions(-)

diff --git a/arch/blackfin/mach-bf609/pm.c b/arch/blackfin/mach-bf609/pm.c
index b1bfcf434d16..dab42d39b085 100644
--- a/arch/blackfin/mach-bf609/pm.c
+++ b/arch/blackfin/mach-bf609/pm.c
@@ -338,21 +338,22 @@ static int __init bf609_init_pm(void)
GPIO_PE12, error);
}

- error = request_irq(irq, test_isr, IRQF_TRIGGER_RISING | IRQF_NO_SUSPEND
- | IRQF_FORCE_RESUME, "gpiope12", NULL);
+ error = request_irq(irq, test_isr, IRQF_TRIGGER_RISING,
+ "gpiope12", NULL);
if(error < 0)
printk(KERN_DEBUG "Unable to get irq\n");
+ enable_irq_wake(irq);
#endif

- error = request_irq(IRQ_CGU_EVT, dpm0_isr, IRQF_NO_SUSPEND |
- IRQF_FORCE_RESUME, "cgu0 event", NULL);
+ error = request_irq(IRQ_CGU_EVT, dpm0_isr, 0, "cgu0 event", NULL);
if(error < 0)
printk(KERN_DEBUG "Unable to get irq\n");
+ enable_irq_wake(IRQ_CGU_EVT);

- error = request_irq(IRQ_DPM, dpm0_isr, IRQF_NO_SUSPEND |
- IRQF_FORCE_RESUME, "dpm0 event", NULL);
+ error = request_irq(IRQ_DPM, dpm0_isr, 0, "dpm0 event", NULL);
if (error < 0)
printk(KERN_DEBUG "Unable to get irq\n");
+ enable_irq_wake(IRQ_DPM);

bfin_cpu_pm = &bf609_cpu_pm;
return 0;
--
1.9.1


\
 
 \ /
  Last update: 2015-09-21 18:01    [W:0.465 / U:7.092 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site