lkml.org 
[lkml]   [2015]   [Sep]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 01/38] arm-cci: fix handling cpumask_any_but return value
On Mon, Sep 21, 2015 at 02:33:33PM +0100, Andrzej Hajda wrote:
> cpumask_any_but returns value >= nr_cpu_ids if there are no more CPUs.
>
> The problem has been detected using proposed semantic patch
> scripts/coccinelle/tests/unsigned_lesser_than_zero.cocci [1].
>
> [1]: http://permalink.gmane.org/gmane.linux.kernel/2038576
>
> Signed-off-by: Andrzej Hajda <a.hajda@samsung.com>
> ---
> drivers/bus/arm-cci.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/bus/arm-cci.c b/drivers/bus/arm-cci.c
> index 577cc4b..22754d0 100644
> --- a/drivers/bus/arm-cci.c
> +++ b/drivers/bus/arm-cci.c
> @@ -1314,7 +1314,7 @@ static int cci_pmu_cpu_notifier(struct notifier_block *self,
> if (!cpumask_test_and_clear_cpu(cpu, &cci_pmu->cpus))
> break;
> target = cpumask_any_but(cpu_online_mask, cpu);
> - if (target < 0) // UP, last CPU
> + if (target >= nr_cpu_ids) // UP, last CPU

We could also make target an int, to match the return type of
cpumask_any_but (on top of this change).

Regardless,

Acked-by: Will Deacon <will.deacon@arm.com>

Will


\
 
 \ /
  Last update: 2015-09-21 17:41    [W:0.052 / U:0.972 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site