Messages in this thread | | | Date | Mon, 21 Sep 2015 16:59:55 +0200 | From | LABBE Corentin <> | Subject | Re: [PATCH v2 5/8] lib: introduce sg_nents_len_chained |
| |
On Mon, Sep 21, 2015 at 10:19:17PM +0800, Herbert Xu wrote: > On Fri, Sep 18, 2015 at 05:25:47PM -0400, Tony Battersby wrote: > > > > So instead of adding a new function sg_nents_len_chained(), a better > > cleanup would be: > > 1) replace the driver-specific functions with calls to sg_nents_for_len() > > 2) get rid of the "chained" variables > > 3) always call dma_map_sg()/dma_unmap_sg() for the entire scatterlist > > regardless of whether or not the scatterlist is chained > > > > Would someone more familiar with the crypto API please confirm that my > > suggestions are correct? > > Yes I think you're absolutely right Tony. Corentin, could you > please take this opportunity to clean up those drivers so that > they simply use dma_map_sg a single time rather than over and > over again for chained SG lists?
Yes I will
> > You only have to redo patches 5-8. > > Thanks,
| |