Messages in this thread | | | Subject | Re: [PATCH v2 2/2] of: changesets: Introduce changeset helper methods | From | Pantelis Antoniou <> | Date | Mon, 21 Sep 2015 15:36:47 +0300 |
| |
Hi Geert,
> On Sep 21, 2015, at 15:35 , Geert Uytterhoeven <geert@linux-m68k.org> wrote: > > Hi Pantelis, > > On Wed, Sep 16, 2015 at 6:11 PM, Pantelis Antoniou > <pantelis.antoniou@konsulko.com> wrote: >> Changesets are very powerful, but the lack of a helper API >> makes using them cumbersome. Introduce a simple copy based >> API that makes things considerably easier. >> >> To wit, adding a property using the raw API. >> >> struct property *prop; >> prop = kzalloc(sizeof(*prop)), GFP_KERNEL); >> prop->name = kstrdup("compatible"); >> prop->value = kstrdup("foo,bar"); >> prop->length = strlen(prop->value) + 1; >> of_changeset_add_property(ocs, np, prop); >> >> while using the helper API >> >> of_changeset_add_property_string(ocs, np, "compatible", >> "foo,bar"); > > What about removing properties? >
Once upon a time there was that capability. It was removed after we didn’t have a good use for them yet. Do you have any? I’d be happy to re-add it :)
> Gr{oetje,eeting}s, > > Geert >
Regards
— Pantelis
> -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds
| |