Messages in this thread | | | From | Kalle Valo <> | Subject | Re: [PATCH] [net] Fix error handling in ezusb_probe() | Date | Mon, 21 Sep 2015 13:24:02 +0300 |
| |
RUC_Soft_Sec <zy900702@163.com> writes:
> Current code assigns 0 to variable 'retval', which makes ezusb_probe() > to return success even if alloc_orinocodev() fails. > > Fix it by checking the return value from alloc_orinocodev() and > assigns '-ENOMEM' to variable 'retval' in the case of error. > > > Signed-off-by: RUC_Soft_Sec <zy900702@163.com>
Please use your real name both in From header and in Signed-off-by line. Also use "orinoco_usb:" as the prefix in the commit title.
> --- > orinoco_usb.c | 1 + > 1 file changed, 1 insertion(+)
This is wrong, the patch should contain the full source path.
-- Kalle Valo
| |