Messages in this thread | | | From | John Youn <> | Subject | Re: [PATCH 7/7] usb: dwc2: refactor common low-level hw code to platform.c | Date | Thu, 3 Sep 2015 01:12:07 +0000 |
| |
On 8/21/2015 5:39 AM, Marek Szyprowski wrote: > DWC2 module on some platforms needs three additional hardware > resources: phy controller, clock and power supply. All of them must be > enabled/activated to properly initialize and operate. This was initially > handled in s3c-hsotg driver, which has been converted to 'gadget' part > of dwc2 driver. Unfortunately, not all of this code got moved to common > platform code, what resulted in accessing DWC2 registers without > enabling low-level hardware resources. This fails for example on Exynos > SoCs. This patch moves all the code for managing those resources to > common platform.c file and provides convenient wrappers for controlling > them. > > Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com> > --- > drivers/usb/dwc2/core.h | 4 +- > drivers/usb/dwc2/gadget.c | 188 +++++----------------------------------- > drivers/usb/dwc2/platform.c | 207 ++++++++++++++++++++++++++++++++++++-------- > 3 files changed, 195 insertions(+), 204 deletions(-) > > diff --git a/drivers/usb/dwc2/core.h b/drivers/usb/dwc2/core.h > index 0ed87620941b..ec820bdf98c0 100644 > --- a/drivers/usb/dwc2/core.h > +++ b/drivers/usb/dwc2/core.h > @@ -690,6 +690,7 @@ struct dwc2_hsotg { > enum usb_dr_mode dr_mode; > unsigned int hcd_enabled:1; > unsigned int gadget_enabled:1; > + unsigned int ll_hw_enabled:1;
It seems like this flag is used to restore the state of the lowlevel_hw on suspend/resume?
I think it is clearer to put the setting/clearing of the flag inside the ll_hw_enable/disable and then check and adjust on suspend/resume. That way you don't have to manage this flag everywhere you call enable/disable().
John
| |